Skip to content

added Urdu language config #6556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 8, 2024
Merged

added Urdu language config #6556

merged 6 commits into from
Jul 8, 2024

Conversation

thisalihassan
Copy link
Contributor

Description

Adds Urdu language setup to config.json to enable Urdu translations on Crowdin

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@thisalihassan thisalihassan requested a review from a team as a code owner March 26, 2024 16:29
@vercel Vercel
Copy link

vercel bot commented Mar 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 8, 2024 1:22pm

@thisalihassan thisalihassan mentioned this pull request Mar 26, 2024
Closed
devlopersabbir
devlopersabbir reviewed Mar 26, 2024
View reviewed changes
Copy link

@devlopersabbir devlopersabbir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's great bro :)

devlopersabbir added a commit to devlopersabbir/nodejs.org that referenced this pull request Mar 26, 2024
@devlopersabbir
[chore 🐱‍🏍] Added Bengali language config nodejs#6556
6fb0bc4
@bmuenzenmeyer bmuenzenmeyer added the i18n Issues/PRs related to the Website Internationalisation label Mar 27, 2024
@thisalihassan
Copy link
Contributor Author

Hi, can I have a follow up on this?

@ovflowd
Copy link
Member

ovflowd commented Apr 12, 2024

Hi, can I have a follow up on this?

We are not merging any related i18n PR until we get our Crowdin integration fixed. Sorry for the waiting.

@bmuenzenmeyer
Copy link
Collaborator

bmuenzenmeyer commented Jun 15, 2024 •
edited
Loading

we need more information here

image

I suspect we might need to also update https://github.com/nodejs/nodejs.org/blob/main/crowdin.yml#L15-L20

@bmuenzenmeyer
Copy link
Collaborator

This PR will need to be rebased or recreated now that #6850 merged.

@thisalihassan
Copy link
Contributor Author

we need more information here

image

I suspect we might need to also update https://github.com/nodejs/nodejs.org/blob/main/crowdin.yml#L15-L20

"ur-IN" is not officially recognized in the same way as "ur-PK" in many internationalization standards.
Urdu as spoken in Pakistan and India is fundamentally the same in terms of syntax and grammar

cc: @bmuenzenmeyer

@bmuenzenmeyer
Copy link
Collaborator

ur-PK added in Crowdin

bmuenzenmeyer
bmuenzenmeyer reviewed Jul 8, 2024
View reviewed changes
@Andrulko
Copy link
Contributor

Andrulko commented Jul 8, 2024

ur code is not officially supported by Crowdin, so it was added as a custom language to the project:
https://crowdin.com/project/nodejs-web/ur

Now you can see expected code I hope!

bmuenzenmeyer
bmuenzenmeyer reviewed Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now we can remove this, since crowdin added ur as a custom language

@thisalihassan @bmuenzenmeyer
Update apps/site/i18n/config.json
e3b8e8a 
Co-authored-by: Brian Muenzenmeyer <[email protected]>
Signed-off-by: Ali Hassan <[email protected]>
@bmuenzenmeyer bmuenzenmeyer added the github_actions:pull-request Trigger Pull Request Checks label Jul 8, 2024
@bmuenzenmeyer bmuenzenmeyer enabled auto-merge July 8, 2024 13:29
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Unit Test Coverage Report

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.312s ⏱️

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Jul 8, 2024
Merged via the queue into nodejs:main with commit f60086c Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmuenzenmeyer bmuenzenmeyer bmuenzenmeyer left review comments

@aymen94 aymen94 aymen94 approved these changes

+1 more reviewer

@devlopersabbir devlopersabbir devlopersabbir left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
i18n Issues/PRs related to the Website Internationalisation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@thisalihassan @ovflowd @bmuenzenmeyer @Andrulko @aymen94 @devlopersabbir