add banner for upcoming 19.0.0 release #4888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Added the
If all three of those are true, feel free to remove the |
Member
Author
|
@nodejs/releasers |
Trott
changed the title
nschonni
reviewed
Oct 18, 2022
BethGriggs
reviewed
Oct 18, 2022
RafaelGSS
approved these changes
Oct 18, 2022
ruyadorno
approved these changes
Oct 18, 2022
BethGriggs
approved these changes
Oct 18, 2022
Member
Author
|
It looks like this landed before 9am Pacific, which means the banner won't show, I don't think until something else lands. |
Member
Author
|
I'm going to force-push a no-op in the hope that will cause the banner to be deployed. |
Member
|
The website was rebuilt and I can see a cdn purge is queued. The queue is processed every five minutes so the website should update around 10 mins past the hour. |
Trott
added a commit
that referenced
this pull request
Oct 18, 2022
* add banner for 19.0.0 release * Update locale/en/site.json * Update locale/en/site.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can't land until the 19.0.0 release announcement is posted.