Skip to content

remove freenode in the other lang versions #3941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 29, 2021
Merged

remove freenode in the other lang versions #3941

merged 3 commits into from
Jun 29, 2021

Conversation

SEWeiTung
Copy link
Contributor

Ref: #3923.

@SEWeiTung SEWeiTung requested a review from a team June 29, 2021 12:29
@SEWeiTung
Copy link
Contributor Author

PS: Some files don't have "Slack" translations, maybe you can do it in your own submits. This is ONLY for remove freenode check.

yous
yous approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@yous yous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for ko

@nschonni nschonni merged commit e42d640 into nodejs:master Jun 29, 2021
@SEWeiTung SEWeiTung deleted the remove_freenode branch June 30, 2021 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@yous yous yous approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SEWeiTung @yous @nschonni