Skip to content

Conversation

@fhemberger
Copy link
Contributor

@fhemberger fhemberger commented Nov 7, 2018

Copy link
Member

@ZYSzys ZYSzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
But IMHO, I wonder if it's better to put this section into about/releases.md since this is release related ?

@richardlau
Copy link
Member

cc @nodejs/release

@fhemberger
Copy link
Contributor Author

@ZYSzys The "Release" page explains more what kind of changes land in version numbers. I'm currently not sure if we need this explanation anyway or if it can be replaced entirely by the release schedule.

Feedback is appreciated.

@ZYSzys
Copy link
Member

ZYSzys commented Nov 7, 2018

I didn't mean replacing the "Release" page with the release schedule, I'm saying can we just add a section called schedule into the "Release" page simply ?

@Trott
Copy link
Member

Trott commented Nov 7, 2018

I agree with @fhemberger's suspicion that https://nodejs.org/en/about/releases/ can be deleted entirely or replaced with the schedule here. Most of it is not very informative.

@fhemberger fhemberger force-pushed the feature/lts-release-plan branch from 69f65d0 to dc7fce8 Compare November 8, 2018 16:15
@fhemberger
Copy link
Contributor Author

Ok, replaced the old "Releases" page entirely with the release schedule. The information wasn't really helpful anyway. PTAL.

@fhemberger
Copy link
Contributor Author

/cc @nodejs/nodejs-fa @nodejs/nodejs-ko @nodejs/nodejs-uk @nodejs/nodejs-cn

ZYSzys and others added 4 commits November 11, 2018 10:05
1. Add release schedule

2. Current => 当前版

3. Translate maintenance & active
Due to the actual table in
#1890, so we can make the
meanings more clear by adding "Date" in the Chinese meanings.
* Korean translation: add release schedule

* Fixed a misspelled word
@fhemberger fhemberger merged commit 95a3bdd into master Nov 11, 2018
fhemberger pushed a commit that referenced this pull request Nov 11, 2018
Due to the actual table in
#1890, so we can make the
meanings more clear by adding "Date" in the Chinese meanings.
@fhemberger
Copy link
Contributor Author

Thanks everybody!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants