Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Jun 11, 2018

Change Logs:

  1. 其他 to 其它
  2. Remove useless spaces, and change English comma to Chinese one.
  3. Sign up for doesn't mean 注册. It means 报名登记参与……. According to the context, 注册订阅 is a right meaning.

@ghost ghost changed the title [Localization] Fix a wrong Chinese usage of 其他 [Localization] Fix some Chinese translations Jun 12, 2018
@fhemberger
Copy link
Contributor

/cc @nodejs/nodejs-cn

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you have spaces between CJK and ASCII chararcters.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, fixed.
PS: Why? The formation recognization?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually you may just remove 注册.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Fixed

@laosb
Copy link

laosb commented Jun 12, 2018

Good job, thank you!

The original issue reported here:
#1685
@ghost
Copy link
Author

ghost commented Jun 12, 2018

You're welcome! All things have all been fixed.

Copy link

@laosb laosb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants