Skip to content

Conversation

@chris--young
Copy link
Contributor

There is a link in the debugging guide that is supposed to lead to the legacy debugging documentation but is currently giving a 404. This pr will fix that by linking to to latest version of the debugger docs.

fixes: nodejs/node#12928

@gibfahn
Copy link
Member

gibfahn commented May 10, 2017

I think it probably makes more sense to just link to the v6.x version of that file, which should stick around permanently.

https://github.com/nodejs/node/blob/v6.x/lib/_debugger.js

@chris--young
Copy link
Contributor Author

@gibfahn makes sense, Node 8 will get rid of the legacy debugger. What do you think about this link https://nodejs.org/dist/latest-v6.x/docs/api/debugger.html instead of linking to GitHub?

@lpinca
Copy link
Member

lpinca commented May 11, 2017

What do you think about this link https://nodejs.org/dist/latest-v6.x/docs/api/debugger.html instead of linking to GitHub?

I think it makes sense.

@chris--young
Copy link
Contributor Author

cool

Copy link
Member

@gibfahn gibfahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

@gibfahn gibfahn merged commit 4aea88b into nodejs:master May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doc link broken

4 participants