404 on https://nodejs.org/static/images/favicons/favicon.ico

[legendecas]

URL:

https://nodejs.org/static/images/favicons/favicon.ico

Browser Name:

Browser Version:

Operating System:

How to reproduce the issue:

The favicon is referenced at https://github.com/nodejs/node/blob/7bc2946293757389468f1fa09714860f8e1147b7/src/inspector_socket_server.cc#L350 on the Chrome devtools page.

[legendecas]

Taking this together with #7382, it will be nice if there are sort of permalinks for these resource files.

[AugustinMauroy]

I understand your pain point. But for node core thing why not use GH raw ping on commit ?

[legendecas]

GitHub raw content domain should work... but why not https://nodejs.org? It feels odd to avoid linking to the website.

[bmuenzenmeyer]

websites are not APIs with semver communication or any guarantee a hotlinked file will remain there. people move around files, they get updated, replaced.

we've made reasonable accommodations for redirects where we know of them - and i just opened a fourth for the favicon #7422

A future-proof way to fix this would be to host it yourself

[legendecas]

A future-proof way to fix this would be to host it yourself

The resource is linked in the Node.js project though. I'm wondering if "host it yourself" here suggests host it on https://nodejs.org?

Thanks for the fix!

[AugustinMauroy]

Imo we should have somewhere ping these file maybe openjs-foundation/artwork

[bmuenzenmeyer]

I'm wondering if "host it yourself" here suggests host

sorry @legendecas i had missed that this path was coming in from the org, not like that chromium one the other day which I felt more strongly we shouldn't automatically accomodate

[ovflowd]

Fixed by #7422