Skip to content

Conversation

@brody4hire
Copy link

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

url

Description of change

Mark ignored return value in node::url::Parse(...) with (void).

This is to resolve an unused result warning in node_url.cc.

This is to resolve an unused result warning in node_url.cc.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 23, 2016
@mscdex mscdex added the url Issues and PRs related to the legacy built-in url module. label Nov 23, 2016
@brody4hire
Copy link
Author

This fix will be submitted as part of a bigger change set ref: #9767 (comment)

@brody4hire brody4hire closed this Nov 24, 2016
@brody4hire brody4hire deleted the node-url-warning-fix branch November 25, 2016 11:30
@TimothyGu TimothyGu added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. url Issues and PRs related to the legacy built-in url module. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants