src,permission: add --allow-inspector ability #59711
Merged
+112
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59711 +/- ##
==========================================
- Coverage 89.93% 88.26% -1.68%
==========================================
Files 667 701 +34
Lines 196790 206759 +9969
Branches 38423 39757 +1334
==========================================
+ Hits 176982 182494 +5512
- Misses 12240 16281 +4041
- Partials 7568 7984 +416
🚀 New features to boost your workflow:
|
RafaelGSS
added
the
semver-minor
|
Ready to review @nodejs/security-wg |
santigimeno
approved these changes
Sep 11, 2025
Comment on lines
42
to
+43
| '--allow-net', | ||
| '--allow-inspector', |
There was a problem hiding this comment.
Use alphabetical order here?
Suggested change
| '--allow-net', | |
| '--allow-inspector', | |
| '--allow-inspector', | |
| '--allow-net', |
There was a problem hiding this comment.
Will do it in a follow-up PR so I don't need to re-run the tests
juanarbol
approved these changes
Sep 11, 2025
RafaelGSS
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 29738c7 |
targos
added
the
backport-requested-v24.x
|
There are many conflicts with v24.x-staging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #48534
Remaining questions:
--allow-inspectorThe test case I included makes sure we won't reintroduce 3df13d5
cc: @nodejs/security-wg