Skip to content

node-api: add warning for NAPI_EXPERIMENTAL #58280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025
Merged

node-api: add warning for NAPI_EXPERIMENTAL #58280

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3422b62
node-api: add warning for NAPI_EXPERIMENTAL
miguelmarcondesf May 11, 2025
5961ebf
node-api: add platform-specific warning
miguelmarcondesf Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/js_native_api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,18 @@
#endif
#endif

#if defined(NAPI_EXPERIMENTAL) && \
!defined(NODE_API_EXPERIMENTAL_NO_WARNING) && \
!defined(NODE_WANT_INTERNALS)
#ifdef _MSC_VER
#pragma message("NAPI_EXPERIMENTAL is enabled. " \
"Experimental features may be unstable.")
#else
#warning "NAPI_EXPERIMENTAL is enabled. " \
"Experimental features may be unstable."
#endif
#endif

#include "js_native_api_types.h"

// If you need __declspec(dllimport), either include <node_api.h> instead, or
Expand Down
Loading