Skip to content

test: fix typos #55341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

test: fix typos #55341

wants to merge 4 commits into from

Conversation

@NathanBaulch
Copy link
Contributor

@NathanBaulch NathanBaulch commented Oct 9, 2024

This is a continuation of #55063 covering all the non-comment fixes.

FWIW, the top typos are:

  • exptected (23)
  • inferrable (19)
  • compatability (13)
  • conent (10)
  • splitted (8)
  • verifiy (7)
  • determing (6)
  • occurence (5)
  • seperator (5)
  • treshold (4)
  • destroyd (4)
  • declaraion (4)
  • inut (4)

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 9, 2024

Review requested:

  • @nodejs/single-executable
  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. web streams labels Oct 9, 2024
vmoroz
vmoroz approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@vmoroz vmoroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MattiasBuelens
MattiasBuelens requested changes Oct 9, 2024
View reviewed changes
@avivkeller avivkeller removed node-api Issues and PRs related to the Node-API. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. web streams labels Oct 9, 2024
@codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (c7cf677) to head (6b461fd).
Report is 24 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #55341   +/-   ##
=======================================
  Coverage   90.25%   90.25%           
=======================================
  Files         630      630           
  Lines      184681   184681           
  Branches    36147    36140    -7     
=======================================
+ Hits       166682   166692   +10     
- Misses      11024    11027    +3     
+ Partials     6975     6962   -13

see 39 files with indirect coverage changes

This was referenced Oct 10, 2024
Merged
Open
mcollina
mcollina approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

bnb
bnb reviewed Feb 27, 2025
View reviewed changes
bnb
bnb requested changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@bnb bnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments! Otherwise this LGTM

mcollina
mcollina approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

mcollina commented Feb 28, 2025

@bnb ptal

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 28, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 28, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 28, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/65491/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 2, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/65515/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnb bnb bnb requested changes

@mcollina mcollina mcollina approved these changes

@vmoroz vmoroz vmoroz approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

@MattiasBuelens MattiasBuelens Awaiting requested review from MattiasBuelens

+2 more reviewers

@avivkeller avivkeller avivkeller left review comments

@aymen94 aymen94 aymen94 approved these changes

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@NathanBaulch @nodejs-github-bot @mcollina @bnb @MattiasBuelens @vmoroz @UlisesGascon @aymen94 @Ethan-Arrowood @avivkeller