Skip to content

meta: remove unneeded ignore rules from ruff #54360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2024
Merged

meta: remove unneeded ignore rules from ruff #54360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21a0a91
meta: remove unneeded ignore rules from ruff
avivkeller Aug 13, 2024
e17556a
Update pyproject.toml
avivkeller Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ exclude = [
"tools/gyp",
"tools/inspector_protocol",
"tools/eslint/node_modules",
"tools/github_reporter"
]
line-length = 172
target-version = "py37"
Expand Down Expand Up @@ -40,12 +41,6 @@ ignore = [
[tool.ruff.lint.mccabe]
max-complexity = 100

[tool.ruff.lint.per-file-ignores]
"tools/checkimports.py" = ["W605"]
"tools/gyp/pylib/gyp/xcodeproj_file.py" = ["PLE0101"]
"tools/icu/shrink-icu-src.py" = ["W605"]
"tools/mkssldef.py" = ["W605"]

[tool.ruff.lint.pylint]
max-args = 12
max-branches = 110
Expand Down
2 changes: 1 addition & 1 deletion tools/icu/shrink-icu-src.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def print_size(fn):
size = (os.stat(fn).st_size) / 1024000
print('%dM\t%s' % (size, fn))

ignore_regex = re.compile('^.*\.(vcxproj|filters|nrm|icu|dat|xml|txt|ac|guess|m4|in|sub|py|mak)$')
ignore_regex = re.compile(r'^.*\.(vcxproj|filters|nrm|icu|dat|xml|txt|ac|guess|m4|in|sub|py|mak)$')

def icu_ignore(dir, files):
subdir = dir[len(options.icusrc)+1::]
Expand Down
Loading