- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 33.7k
 
test: mark test-runner-watch-mode as flaky #49627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    1f09cc1    to
    23c8b83      
    Compare
  
    | 
           Actually it's flaky on both Linux and Windows. nodejs/reliability#663 Added windows to the condition.  | 
    
      
        
      
      
  
    14 tasks
  
              
                    anonrig
  
              
              approved these changes
              
                  
                    Sep 13, 2023 
                  
              
              
            
            
              
                    LiviaMedeiros
  
              
              approved these changes
              
                  
                    Sep 13, 2023 
                  
              
              
            
            
              
                    watilde
  
              
              approved these changes
              
                  
                    Sep 13, 2023 
                  
              
              
            
            
      
        
      
      
  
    15 tasks
  
| 
           Landed in b289c6d  | 
    
  This was referenced Sep 15, 2023 
      
    
  ruyadorno 
      pushed a commit
      that referenced
      this pull request
    
      Sep 28, 2023 
    
    
      
  
    
      
    
  
PR-URL: #49627 Refs: #49605 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
    
  alexfernandez 
      pushed a commit
        to alexfernandez/node
      that referenced
      this pull request
    
      Nov 1, 2023 
    
    
      
  
    
      
    
  
PR-URL: nodejs#49627 Refs: nodejs#49605 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
    
  targos 
      pushed a commit
      that referenced
      this pull request
    
      Nov 27, 2023 
    
    
      
  
    
      
    
  
PR-URL: #49627 Refs: #49605 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
    
  sercher 
      added a commit
        to sercher/graaljs
      that referenced
      this pull request
    
      Apr 25, 2024 
    
    
      
  
    
      
    
  
PR-URL: nodejs/node#49627 Refs: nodejs/node#49605 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
    
  sercher 
      added a commit
        to sercher/graaljs
      that referenced
      this pull request
    
      Apr 25, 2024 
    
    
      
  
    
      
    
  
PR-URL: nodejs/node#49627 Refs: nodejs/node#49605 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    author ready
  PRs that have at least one approval, no pending requests for changes, and a CI started. 
  
    needs-ci
  PRs that need a full CI run. 
  
    test
  Issues and PRs related to the tests. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Refs: #49605