Skip to content

Conversation

@zero1seven
Copy link

As of Python 3.5, the tarfile extractall() method has a numeric_owner keyword argument. This is change will support Python 3.5 and higher. Note that this keyword does not exist in Python 3.4 or lower so it will not work on those previous versions.

@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels Oct 10, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve.

@mscdex
Copy link
Contributor

mscdex commented Oct 10, 2022

These changes need to be made upstream in the node-gyp project instead (as with nodejs/node-gyp#2741).

@legendecas legendecas removed the fast-track PRs that do not need to wait for 48 hours to land. label Oct 11, 2022
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As indicated, this change isn't appropriate here.

@jasnell jasnell closed this Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants