src: restore context default IsCodeGenerationFromStringsAllowed value #44324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
legendecas
force-pushed
the
issue-44287
branch
from
106dc81 to
e9c7c28
Compare
joyeecheung
reviewed
Aug 21, 2022
joyeecheung
reviewed
Aug 21, 2022
legendecas
force-pushed
the
issue-44287
branch
from
e9c7c28 to
e118eda
Compare
github-actions
bot
removed
the
request-ci
joyeecheung
approved these changes
Aug 23, 2022
Context's default IsCodeGenerationFromStringsAllowed value can be changed by v8 flag `--disallow-code-generation-from-strings`. Restore the value at runtime when delegating the code generation validation to `node::ModifyCodeGenerationFromStrings`. The context's settings are serialized in the snapshot. Reset the setting values to its default values before the serialization so that it can be correctly re-initialized after deserialization at runtime.
legendecas
force-pushed
the
issue-44287
branch
from
280b1eb to
38b97cc
Compare
|
Rebased and resolved conflicts. |
github-actions
bot
removed
the
request-ci
This was referenced Aug 24, 2022
jasnell
approved these changes
Aug 28, 2022
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 3370e7c |
30 tasks
This was referenced Aug 30, 2022
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 5, 2022
Context's default IsCodeGenerationFromStringsAllowed value can be changed by v8 flag `--disallow-code-generation-from-strings`. Restore the value at runtime when delegating the code generation validation to `node::ModifyCodeGenerationFromStrings`. The context's settings are serialized in the snapshot. Reset the setting values to its default values before the serialization so that it can be correctly re-initialized after deserialization at runtime. PR-URL: #44324 Fixes: #44287 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fyko
pushed a commit
to Fyko/node
that referenced
this pull request
Sep 15, 2022
Context's default IsCodeGenerationFromStringsAllowed value can be changed by v8 flag `--disallow-code-generation-from-strings`. Restore the value at runtime when delegating the code generation validation to `node::ModifyCodeGenerationFromStrings`. The context's settings are serialized in the snapshot. Reset the setting values to its default values before the serialization so that it can be correctly re-initialized after deserialization at runtime. PR-URL: nodejs#44324 Fixes: nodejs#44287 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Sadly, this is not landing cleanly on the v16.x branch; it depends on #43531 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context's default IsCodeGenerationFromStringsAllowed value can be
changed by v8 flag
--disallow-code-generation-from-strings. Restorethe value at runtime when delegating the code generation validation to
node::ModifyCodeGenerationFromStrings.The context's settings are serialized in the snapshot. Reset the setting
values to its default values before the serialization so that it can be
correctly re-initialized after deserialization at runtime.
Fixes: #44287