Skip to content

src: per-environment time origin value #43781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

src: per-environment time origin value #43781

wants to merge 2 commits into from

Conversation

legendecas
Copy link
Member

According to https://html.spec.whatwg.org/#environment-settings-object,
the timeOrigin is a per-environment value. Worker's timeOrigin is the time
when the worker is created
(https://html.spec.whatwg.org/multipage/workers.html#set-up-a-worker-environment-settings-object).

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 11, 2022
@legendecas legendecas force-pushed the per-environment-time-origin branch from 7ac16b7 to 9c35bf1 Compare July 11, 2022 16:31
@legendecas
src: per-environment time origin value
bad53ff 
According to https://html.spec.whatwg.org/#environment-settings-object,
the timeOrigin is a per-environment value. Worker's timeOrigin is the
time when the worker is created.
@legendecas legendecas force-pushed the per-environment-time-origin branch from 9c35bf1 to bad53ff Compare July 11, 2022 16:33
@legendecas legendecas added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jul 11, 2022
@legendecas
Copy link
Member Author

Sorry about tagging the "author ready" label to the wrong PR.

mcollina
mcollina approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

I'm unsure about the semversiness of this. worker_threads do not implement the WHATWG Workers spec, so I'm inclined to treat this as semver-major, but I'd be happy to consider a minor too.

cc @addaleax

addaleax
addaleax approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On semver: 🤷‍♀️ This feels like a bug fix but, honestly, unless there’s any urgency to get this out, why not make it semver-major?

@legendecas legendecas added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jul 12, 2022
joyeecheung
joyeecheung reviewed Jul 12, 2022
View reviewed changes
ShogunPanda
ShogunPanda approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joyeecheung
Copy link
Member

+1 to making this semver-major.

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 12, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 12, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45353/

@legendecas legendecas added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 13, 2022
@legendecas
Copy link
Member Author

This PR is semver-major so we need one more TSC approval. @joyeecheung would you mind taking a look at this again? Thank you!

@legendecas
Copy link
Member Author

Landed in dabda03. Thank you for reviewing!

@legendecas legendecas closed this Jul 16, 2022
@legendecas legendecas deleted the per-environment-time-origin branch July 16, 2022 08:47
@legendecas legendecas mentioned this pull request Jul 25, 2022
Closed
This was referenced Oct 14, 2022
Merged
Closed
@theanarkh theanarkh mentioned this pull request Dec 23, 2022
Closed
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
@legendecas legendecas mentioned this pull request Feb 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@addaleax addaleax addaleax approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@legendecas @nodejs-github-bot @mcollina @joyeecheung @ShogunPanda @addaleax