test: deflake http2-cancel-while-client-reading #40659
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing `'error'` event handler. Fixes: nodejs#40610
nodejs-github-bot
added
needs-ci
|
This fixes the issue on my machine but I'm not sure if it invalidates the test. cc: @nodejs/http2 @kumarak |
This was referenced Nov 1, 2021
kumarak
approved these changes
Nov 3, 2021
Trott
approved these changes
Nov 3, 2021
44 tasks
lpinca
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 8fce09e...0a62026 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 4, 2021
Add missing `'error'` event handler. Fixes: #40610 PR-URL: #40659 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]>
This was referenced Nov 5, 2021
targos
pushed a commit
that referenced
this pull request
Nov 6, 2021
Add missing `'error'` event handler. Fixes: #40610 PR-URL: #40659 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]>
This was referenced Nov 7, 2021
23 tasks
BethGriggs
pushed a commit
that referenced
this pull request
Nov 25, 2021
Add missing `'error'` event handler. Fixes: #40610 PR-URL: #40659 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing
'error'event handler.Fixes: #40610