Skip to content

Conversation

darcyclarke
Copy link
Member

6.14.14 (2021-07-27)

DEPENDENCIES

@github-actions github-actions bot added dont-land-on-v12.x fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels Jul 27, 2021
@nodejs-github-bot
Copy link
Collaborator

@richardlau
Copy link
Member

@nodejs/actions Anyone know why the labelling workflow added dont-land-on-v14.x/dont-land-on-v12.x labels to this PR? Is the workflow picking up the label config from master rather than v14.x-staging?

@targos
Copy link
Member

targos commented Jul 28, 2021

Is the workflow picking up the label config from master rather than v14.x-staging?

Yes, and it's intended: https://github.com/nodejs/node-pr-labeler/blob/d4cf1b8b9f23189c37917000e5e17e796c770a6b/index.js#L47

@richardlau
Copy link
Member

Is the workflow picking up the label config from master rather than v14.x-staging?

Yes, and it's intended: https://github.com/nodejs/node-pr-labeler/blob/d4cf1b8b9f23189c37917000e5e17e796c770a6b/index.js#L47

Thanks. It'll apply the wrong labels to npm PRs to LTS, but maybe that's infrequent enough that we just live with it and manually adjust?

@aduh95 aduh95 changed the title deps: upgrade npm to 6.14.14 [v14.x] deps: upgrade npm to 6.14.14 Jul 28, 2021
richardlau pushed a commit that referenced this pull request Jul 28, 2021
PR-URL: #39553
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
@richardlau
Copy link
Member

Landed in 7557130

@richardlau richardlau closed this Jul 28, 2021
richardlau pushed a commit that referenced this pull request Jul 28, 2021
PR-URL: #39553
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 28, 2021
PR-URL: #39553
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 28, 2021
PR-URL: #39553
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
This was referenced Jul 28, 2021
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
PR-URL: nodejs#39553
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
@wraithgar wraithgar deleted the npm-6.14.14 branch June 26, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants