Skip to content

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 19, 2021

There's no reason to keep these tests separated from everything else.

@github-actions github-actions bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 19, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

There's no reason to keep these tests separated from everything else.

PR-URL: nodejs#39079
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jun 21, 2021

Landed in 15ad006

@Trott Trott merged commit 15ad006 into nodejs:master Jun 21, 2021
@Trott Trott deleted the mv-test branch June 21, 2021 02:39
danielleadams pushed a commit that referenced this pull request Jun 21, 2021
There's no reason to keep these tests separated from everything else.

PR-URL: #39079
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 21, 2021
codebytere added a commit to electron/electron that referenced this pull request Jun 24, 2021
codebytere added a commit to electron/electron that referenced this pull request Jun 24, 2021
richardlau pushed a commit that referenced this pull request Jul 19, 2021
There's no reason to keep these tests separated from everything else.

PR-URL: #39079
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
There's no reason to keep these tests separated from everything else.

PR-URL: #39079
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@richardlau richardlau mentioned this pull request Jul 20, 2021
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
There's no reason to keep these tests separated from everything else.

PR-URL: nodejs#39079
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants