Skip to content

n-api: improve consistency of how we get context #36068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

n-api: improve consistency of how we get context #36068

wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

Refs: nodejs/node-addon-api#764
Improve the consistency of how we get a context
when needed. We generally used env->context() in N-API
but there were are few exceptions that this PR addresses.

Signed-off-by: Michael Dawson [email protected]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@mhdawson
n-api: improve consistency of how we get context
9f559af 
Refs: nodejs/node-addon-api#764
Improve the consistency of how we get a context
when needed. We generally used env->context() in N-API
but there were are few exceptions that this PR addresses.

Signed-off-by: Michael Dawson <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 10, 2020 •
edited by mhdawson
Loading

Review requested:

  • @nodejs/n-api

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 10, 2020
NickNaso
NickNaso approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrielschulhof gabrielschulhof added the node-api Issues and PRs related to the Node-API. label Nov 10, 2020
@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 11, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 11, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34351/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34393/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34418/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34419/

@mhdawson
Copy link
Member Author

CI is green will land.

mhdawson added a commit that referenced this pull request Nov 17, 2020
@mhdawson
n-api: improve consistency of how we get context
cbfa2d1 
Refs: nodejs/node-addon-api#764
Improve the consistency of how we get a context
when needed. We generally used env->context() in N-API
but there were are few exceptions that this PR addresses.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #36068
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@mhdawson
Copy link
Member Author

Landed in cbfa2d1

@mhdawson mhdawson closed this Nov 17, 2020
codebytere pushed a commit that referenced this pull request Nov 22, 2020
@mhdawson @codebytere
n-api: improve consistency of how we get context
3d623d8 
Refs: nodejs/node-addon-api#764
Improve the consistency of how we get a context
when needed. We generally used env->context() in N-API
but there were are few exceptions that this PR addresses.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #36068
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@codebytere codebytere mentioned this pull request Nov 22, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@mhdawson @BethGriggs
n-api: improve consistency of how we get context
b42949f 
Refs: nodejs/node-addon-api#764
Improve the consistency of how we get a context
when needed. We generally used env->context() in N-API
but there were are few exceptions that this PR addresses.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #36068
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@mhdawson @BethGriggs
n-api: improve consistency of how we get context
4b383e1 
Refs: nodejs/node-addon-api#764
Improve the consistency of how we get a context
when needed. We generally used env->context() in N-API
but there were are few exceptions that this PR addresses.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #36068
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@mhdawson @BethGriggs
n-api: improve consistency of how we get context
dde727e 
Refs: nodejs/node-addon-api#764
Improve the consistency of how we get a context
when needed. We generally used env->context() in N-API
but there were are few exceptions that this PR addresses.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #36068
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@gabrielschulhof gabrielschulhof gabrielschulhof approved these changes

@benjamingr benjamingr benjamingr approved these changes

@legendecas legendecas legendecas approved these changes

@juanarbol juanarbol juanarbol approved these changes

+1 more reviewer

@NickNaso NickNaso NickNaso approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mhdawson @nodejs-github-bot @NickNaso @Trott @gabrielschulhof @benjamingr @legendecas @juanarbol