doc: improve kbd element rendering #35497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before:
After:
|
|
Magnified before:
Magnified after:
|
|
@silverwind Does the light padding at the top work for you now? Do you think we should get rid of it entirely? |
addaleax
approved these changes
Oct 4, 2020
|
New white padding looks almost unnoticable and I'm not sure if it's really adding something, I'd probably get rid of it. |
jasnell
approved these changes
Oct 4, 2020
lpinca
approved these changes
Oct 5, 2020
@silverwind Got rid of it.
|
* better vertical alignment with text * slightly larger "key" size * remove top light area (from box-shadow) PR-URL: nodejs#35497 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in ce84bac |
BethGriggs
pushed a commit
that referenced
this pull request
Oct 13, 2020
* better vertical alignment with text * slightly larger "key" size * remove top light area (from box-shadow) PR-URL: #35497 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
* better vertical alignment with text * slightly larger "key" size * remove top light area (from box-shadow) PR-URL: nodejs#35497 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist