Skip to content

Conversation

watilde
Copy link
Contributor

@watilde watilde commented Sep 1, 2020

Related: #33892
Fixes: #35012

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@watilde watilde added the querystring Issues and PRs related to the built-in querystring module. label Sep 1, 2020
@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 2, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 2, 2020
@nodejs-github-bot
Copy link
Collaborator

@watilde watilde requested a review from joyeecheung September 2, 2020 07:57
@nodejs-github-bot
Copy link
Collaborator

Related: nodejs#33892
Fixes: nodejs#35012

PR-URL: nodejs#35013
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott
Copy link
Member

Trott commented Sep 4, 2020

Landed in 3b92521

@Trott Trott merged commit 3b92521 into nodejs:master Sep 4, 2020
@watilde watilde deleted the fixes-35012 branch September 4, 2020 03:58
@watilde
Copy link
Contributor Author

watilde commented Sep 4, 2020

Thank you

watilde added a commit to watilde/node that referenced this pull request Sep 4, 2020
richardlau pushed a commit that referenced this pull request Sep 7, 2020
Related: #33892
Fixes: #35012

PR-URL: #35013
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@richardlau richardlau mentioned this pull request Sep 7, 2020
4 tasks
richardlau pushed a commit that referenced this pull request Sep 7, 2020
Related: #33892
Fixes: #35012

PR-URL: #35013
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Related: #33892
Fixes: #35012

PR-URL: #35013
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Related: #33892
Fixes: #35012

PR-URL: #35013
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
Related: nodejs#33892
Fixes: nodejs#35012

PR-URL: nodejs#35013
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
querystring Issues and PRs related to the built-in querystring module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

querystring.unescape does not correctly unescape percent characters
6 participants