[v12.x backport] tools: enable no-else-return lint rule #34275
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
lib / src
Refs: nodejs#32644 Refs: nodejs#32662 PR-URL: nodejs#32667 Backport-PR-URL: nodejs#34275 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
lpinca
force-pushed
the
backport-32667-to-v12.x
branch
from
c17687e to
441e6d9
Compare
codebytere
approved these changes
Jul 10, 2020
|
@nodejs/releasers would someone mind taking a second look so i don't need to wait another 90hrs to land? |
targos
approved these changes
Jul 13, 2020
|
Landed in a131c72 |
codebytere
pushed a commit
that referenced
this pull request
Jul 13, 2020
Refs: #32644 Refs: #32662 PR-URL: #32667 Backport-PR-URL: #34275 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jul 14, 2020
Refs: #32644 Refs: #32662 PR-URL: #32667 Backport-PR-URL: #34275 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #32644
Refs: #32662
PR-URL: #32667
Reviewed-By: Ruben Bridgewater [email protected]
Reviewed-By: Trivikram Kamat [email protected]
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes