Skip to content

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Jun 27, 2019

@nodejs/releasers @BridgeAR

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@devsnek devsnek added doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. labels Jun 27, 2019
@devsnek
Copy link
Member Author

devsnek commented Jun 27, 2019

lite ci https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3724/

please thumbs up to fast track

PR-URL: #28450
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@devsnek
Copy link
Member Author

devsnek commented Jun 27, 2019

Landed in fd3a0d3

@devsnek devsnek merged commit fd3a0d3 into master Jun 27, 2019
@targos
Copy link
Member

targos commented Jun 27, 2019

The fix should ideally be ported to the blog post on nodejs/nodejs.org

@devsnek devsnek deleted the devsnek-patch-1 branch June 27, 2019 15:55
@devsnek
Copy link
Member Author

devsnek commented Jun 27, 2019

@targos nodejs/nodejs.org#2300

targos pushed a commit that referenced this pull request Jul 2, 2019
PR-URL: #28450
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
targos pushed a commit that referenced this pull request Jul 2, 2019
PR-URL: #28450
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@targos targos mentioned this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants