Skip to content

[v10.x backport] src: promote v8 name spaces with using #25005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[v10.x backport] src: promote v8 name spaces with using #25005

wants to merge 1 commit into from

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Dec 13, 2018

Refs: #23934

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. util Issues and PRs related to the built-in util module. v10.x labels Dec 13, 2018
bnoordhuis
bnoordhuis approved these changes Jan 6, 2019
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. Overly cautious CI: https://ci.nodejs.org/job/node-test-pull-request/19958/

@codebytere codebytere force-pushed the v10.x-staging branch 3 times, most recently from 2d6e145 to 7840f71 Compare January 29, 2019 18:12
@BethGriggs
Copy link
Member

Another CI before landing - https://ci.nodejs.org/job/node-test-commit/25585/

@BethGriggs
Copy link
Member

BethGriggs commented Feb 4, 2019 •
edited
Loading

Landed in 450bcde

@BethGriggs BethGriggs closed this Feb 4, 2019
BethGriggs pushed a commit that referenced this pull request Feb 4, 2019
@ZYSzys @BethGriggs
src: use v8:: for consistency in util
450bcde 
Backport-PR-URL: #25005
PR-URL: #23934
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@ZYSzys ZYSzys deleted the backport-23934-to-v10.x branch February 5, 2019 08:36
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@ZYSzys @rvagg
src: use v8:: for consistency in util
f9fc1ea 
Backport-PR-URL: #25005
PR-URL: #23934
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZYSzys @BethGriggs @bnoordhuis @nodejs-github-bot