Skip to content

test: fixing arguments order in assert.strictEqual() #24192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

test: fixing arguments order in assert.strictEqual() #24192

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa9b473
test: fixing arguments order in assert.strictEqual()
ulisesantana Nov 6, 2018
7fe0ec4
test: fixing arguments order in assert.strictEqual()
ulisesantana Nov 7, 2018
bce54bf
f: swap server_response expected_response
trivikr Nov 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions test/parallel/test-http-1.0.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@ function test(handler, request_generator, response_validator) {

{
function handler(req, res) {
assert.strictEqual('1.0', req.httpVersion);
assert.strictEqual(1, req.httpVersionMajor);
assert.strictEqual(0, req.httpVersionMinor);
assert.strictEqual(req.httpVersion, '1.0');
assert.strictEqual(req.httpVersionMajor, 1);
assert.strictEqual(req.httpVersionMinor, 0);
res.writeHead(200, { 'Content-Type': 'text/plain' });
res.end(body);
}
Expand All @@ -72,8 +72,8 @@ function test(handler, request_generator, response_validator) {
function response_validator(server_response, client_got_eof, timed_out) {
const m = server_response.split('\r\n\r\n');
assert.strictEqual(m[1], body);
assert.strictEqual(true, client_got_eof);
assert.strictEqual(false, timed_out);
assert.strictEqual(client_got_eof, true);
assert.strictEqual(timed_out, false);
}

test(handler, request_generator, response_validator);
Expand All @@ -86,9 +86,9 @@ function test(handler, request_generator, response_validator) {
//
{
function handler(req, res) {
assert.strictEqual('1.0', req.httpVersion);
assert.strictEqual(1, req.httpVersionMajor);
assert.strictEqual(0, req.httpVersionMinor);
assert.strictEqual(req.httpVersion, '1.0');
assert.strictEqual(req.httpVersionMajor, 1);
assert.strictEqual(req.httpVersionMinor, 0);
res.sendDate = false;
res.writeHead(200, { 'Content-Type': 'text/plain' });
res.write('Hello, '); res._send('');
Expand All @@ -112,19 +112,19 @@ function test(handler, request_generator, response_validator) {
'\r\n' +
'Hello, world!';

assert.strictEqual(expected_response, server_response);
assert.strictEqual(true, client_got_eof);
assert.strictEqual(false, timed_out);
assert.strictEqual(server_response, expected_response);
assert.strictEqual(client_got_eof, true);
assert.strictEqual(timed_out, false);
}

test(handler, request_generator, response_validator);
}

{
function handler(req, res) {
assert.strictEqual('1.1', req.httpVersion);
assert.strictEqual(1, req.httpVersionMajor);
assert.strictEqual(1, req.httpVersionMinor);
assert.strictEqual(req.httpVersion, '1.1');
assert.strictEqual(req.httpVersionMajor, 1);
assert.strictEqual(req.httpVersionMinor, 1);
res.sendDate = false;
res.writeHead(200, { 'Content-Type': 'text/plain' });
res.write('Hello, '); res._send('');
Expand Down Expand Up @@ -155,9 +155,9 @@ function test(handler, request_generator, response_validator) {
'0\r\n' +
'\r\n';

assert.strictEqual(expected_response, server_response);
assert.strictEqual(true, client_got_eof);
assert.strictEqual(false, timed_out);
assert.strictEqual(server_response, expected_response);
assert.strictEqual(client_got_eof, true);
assert.strictEqual(timed_out, false);
}

test(handler, request_generator, response_validator);
Expand Down