src: use unqualified names in module_wrap.cc #20594
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the usage of qualified names for consistency.
nodejs-github-bot
added
the
c++
devsnek
approved these changes
May 8, 2018
cjihrig
approved these changes
May 8, 2018
jasnell
approved these changes
May 8, 2018
TimothyGu
approved these changes
May 9, 2018
addaleax
approved these changes
May 9, 2018
addaleax
added
the
author ready
tniessen
approved these changes
May 9, 2018
node-test-linux-linux failure looks unrelated08:01:01 not ok 2115 sequential/test-fs-readfile-tostring-fail
08:01:01 ---
08:01:01 duration_ms: 121.18
08:01:01 severity: fail
08:01:01 exitcode: -15
08:01:01 stack: |-
08:01:01 timeout
08:01:01 ... node-test-linux-linked-withoutintl failure looks unrelated07:56:00 not ok 2115 sequential/test-fs-readfile-tostring-fail
07:56:00 ---
07:56:00 duration_ms: 120.786
07:56:00 severity: fail
07:56:00 exitcode: -15
07:56:00 stack: |-
07:56:00 timeout
07:56:00 ... |
|
Landed in b267d2a. |
danbev
added a commit
to danbev/node
that referenced
this pull request
May 10, 2018
This commit removes the usage of qualified names for consistency. PR-URL: nodejs#20594 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
devsnek
removed
the
author ready
targos
pushed a commit
that referenced
this pull request
May 12, 2018
This commit removes the usage of qualified names for consistency. PR-URL: #20594 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the usage of qualified names for consistency.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes