Revert 19560: npm 5.8.0 #19837
Closed
Revert 19560: npm 5.8.0 #19837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
npm
devsnek
approved these changes
Apr 5, 2018
jasnell
approved these changes
Apr 5, 2018
addaleax
added a commit
that referenced
this pull request
Apr 5, 2018
This reverts commit 55557ba. PR-URL: #19837 Reviewed-By: Gus Caplan <[email protected]>
addaleax
added a commit
that referenced
this pull request
Apr 5, 2018
This reverts commit 25a816d. PR-URL: #19837 Reviewed-By: Gus Caplan <[email protected]>
|
ugh... sorry about this... thought everything was working |
|
@MylesBorins Don’t worry, these things happen :) |
|
Oh I know... I break stuff all the time 🎉 Just like apologizing 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaks CI and local tests. These are clean reverts of the commits on top of
master, so let’s land this ASAP.