Skip to content

test: use common.mustCall in http test #17439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

test: use common.mustCall in http test #17439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions test/parallel/test-http-malformed-request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,27 +20,22 @@
// USE OR OTHER DEALINGS IN THE SOFTWARE.

'use strict';
require('../common');
const assert = require('assert');
const common = require('../common');
const net = require('net');
const http = require('http');
const url = require('url');

// Make sure no exceptions are thrown when receiving malformed HTTP
// requests.

let nrequests_completed = 0;
const nrequests_expected = 1;

const server = http.createServer(function(req, res) {
const server = http.createServer(common.mustCall((req, res) => {
console.log(`req: ${JSON.stringify(url.parse(req.url))}`);

res.writeHead(200, { 'Content-Type': 'text/plain' });
res.write('Hello World');
res.end();

if (++nrequests_completed === nrequests_expected) server.close();
});
server.close();
}));
server.listen(0);

server.on('listening', function() {
Expand All @@ -50,7 +45,3 @@ server.on('listening', function() {
c.end();
});
});

process.on('exit', function() {
assert.strictEqual(nrequests_expected, nrequests_completed);
});