core: set PROVIDER type as Persistent class id #1730
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass along the PROVIDER type, that is already passed to AsyncWrap, along to BaseObject to set the handle_'s class id. This will allow all Persistents to be transversed and uniquely identified by what type they are using APIs such as v8::PersistentHandleVisitor.
|
For anyone wondering about possible performance implications, I haven't been able to measure any difference at even the nanosecond level of any micro-benchmarks. |
brendanashworth
added
the
c++
| inline BaseObject::BaseObject(Environment* env, v8::Local<v8::Object> handle) | ||
| inline BaseObject::BaseObject(Environment* env, | ||
| v8::Local<v8::Object> handle, | ||
| const uint16_t p_id) |
There was a problem hiding this comment.
Can I suggest you call it class_id? p_id leaves the reader guessing.
|
LGTM with a suggestion. |
trevnorris
added a commit
that referenced
this pull request
May 19, 2015
Pass along the PROVIDER type, that is already passed to AsyncWrap, along to BaseObject to set the handle_'s class id. This will allow all Persistents to be transversed and uniquely identified by what type they are using APIs such as v8::PersistentHandleVisitor. PR-URL: #1730 Reviewed-By: Ben Noordhuis <[email protected]>
|
Thanks. Landed w/ suggestion in 3c44100. |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
May 19, 2015
Pass along the PROVIDER type, that is already passed to AsyncWrap, along to BaseObject to set the handle_'s class id. This will allow all Persistents to be transversed and uniquely identified by what type they are using APIs such as v8::PersistentHandleVisitor. PR-URL: nodejs#1730 Reviewed-By: Ben Noordhuis <[email protected]>
andrewdeandrade
pushed a commit
to andrewdeandrade/node
that referenced
this pull request
Jun 3, 2015
Pass along the PROVIDER type, that is already passed to AsyncWrap, along to BaseObject to set the handle_'s class id. This will allow all Persistents to be transversed and uniquely identified by what type they are using APIs such as v8::PersistentHandleVisitor. PR-URL: nodejs/node#1730 Reviewed-By: Ben Noordhuis <[email protected]>
3 tasks
This was referenced Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass along the PROVIDER type, that is already passed to AsyncWrap, along
to BaseObject to set the handle_'s class id. This will allow all
Persistents to be transversed and uniquely identified by what type they
are using APIs such as v8::PersistentHandleVisitor.
R=@bnoordhuis