Skip to content

Fix two compiler warnings #16726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2017
Merged

Fix two compiler warnings #16726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9087a1d
src: fix -Winconsistent-missing-override warning
bnoordhuis Nov 3, 2017
02bad59
src: fix -Wunused-result warning
bnoordhuis Nov 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/env.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ void CollectExceptionInfo(Environment* env,

if (syscall != nullptr) {
obj->Set(env->context(), env->syscall_string(),
OneByteString(env->isolate(), syscall));
OneByteString(env->isolate(), syscall)).FromJust();
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/node_http2.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ class Http2Session : public AsyncWrap,
const SubmitTrailers& submit_trailers) override;

void Send(WriteWrap* req, char* buf, size_t length) override;
WriteWrap* AllocateSend();
WriteWrap* AllocateSend() override;

int DoWrite(WriteWrap* w, uv_buf_t* bufs, size_t count,
uv_stream_t* send_handle) override;
Expand Down