Skip to content

test: fix flaky test-http2-server-rst-stream.js #16690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

test: fix flaky test-http2-server-rst-stream.js #16690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 35 additions & 58 deletions test/parallel/test-http2-server-rst-stream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,75 +5,52 @@ if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');
const Countdown = require('../common/countdown');

const {
HTTP2_HEADER_METHOD,
HTTP2_HEADER_PATH,
HTTP2_METHOD_POST,
NGHTTP2_CANCEL,
NGHTTP2_NO_ERROR,
NGHTTP2_PROTOCOL_ERROR,
NGHTTP2_REFUSED_STREAM,
NGHTTP2_INTERNAL_ERROR
} = http2.constants;

const errCheck = common.expectsError({ code: 'ERR_HTTP2_STREAM_ERROR' }, 6);
const tests = [
['rstStream', NGHTTP2_NO_ERROR, false],
['rstWithNoError', NGHTTP2_NO_ERROR, false],
['rstWithProtocolError', NGHTTP2_PROTOCOL_ERROR, true],
['rstWithCancel', NGHTTP2_CANCEL, false],
['rstWithRefuse', NGHTTP2_REFUSED_STREAM, true],
['rstWithInternalError', NGHTTP2_INTERNAL_ERROR, true]
];

const server = http2.createServer();
server.on('stream', (stream, headers) => {
const method = headers['rstmethod'];
stream[method]();
});

server.listen(0, common.mustCall(() => {
const client = http2.connect(`http://localhost:${server.address().port}`);

const countdown = new Countdown(tests.length, common.mustCall(() => {
client.destroy();
server.close();
}));

function checkRstCode(rstMethod, expectRstCode) {
const server = http2.createServer();
server.on('stream', (stream, headers, flags) => {
stream.respond({
'content-type': 'text/html',
':status': 200
tests.forEach((test) => {
const req = client.request({
':method': 'POST',
rstmethod: test[0]
});
stream.write('test');
if (rstMethod === 'rstStream')
stream[rstMethod](expectRstCode);
else
stream[rstMethod]();

if (expectRstCode !== NGHTTP2_NO_ERROR &&
expectRstCode !== NGHTTP2_CANCEL) {
stream.on('error', common.mustCall(errCheck));
} else {
stream.on('error', common.mustNotCall());
}
});

server.listen(0, common.mustCall(() => {
const port = server.address().port;
const client = http2.connect(`http://localhost:${port}`);

const headers = {
[HTTP2_HEADER_PATH]: '/',
[HTTP2_HEADER_METHOD]: HTTP2_METHOD_POST
};
const req = client.request(headers);

req.setEncoding('utf8');
req.on('streamClosed', common.mustCall((actualRstCode) => {
assert.strictEqual(
expectRstCode, actualRstCode, `${rstMethod} is not match rstCode`);
server.close();
client.destroy();
req.on('streamClosed', common.mustCall((code) => {
assert.strictEqual(code, test[1]);
countdown.dec();
}));
req.on('data', common.mustCall());
req.on('aborted', common.mustCall());
req.on('end', common.mustCall());

if (expectRstCode !== NGHTTP2_NO_ERROR &&
expectRstCode !== NGHTTP2_CANCEL) {
req.on('error', common.mustCall(errCheck));
} else {
if (test[2])
req.on('error', common.mustCall());
else
req.on('error', common.mustNotCall());
}

}));
}

checkRstCode('rstStream', NGHTTP2_NO_ERROR);
checkRstCode('rstWithNoError', NGHTTP2_NO_ERROR);
checkRstCode('rstWithProtocolError', NGHTTP2_PROTOCOL_ERROR);
checkRstCode('rstWithCancel', NGHTTP2_CANCEL);
checkRstCode('rstWithRefuse', NGHTTP2_REFUSED_STREAM);
checkRstCode('rstWithInternalError', NGHTTP2_INTERNAL_ERROR);
});
}));