Skip to content

async_hooks: enable runtime checks by default #16318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

async_hooks: enable runtime checks by default #16318

wants to merge 1 commit into from

Conversation

AndreasMadsen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

async_hooks

/cc @nodejs/async_hooks @mscdex @refack @trevnorris @mcollina @jasnell @addaleax
cc is based on activity in #15454

@AndreasMadsen AndreasMadsen added async_hooks Issues and PRs related to the async hooks subsystem. async_wrap labels Oct 19, 2017
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 19, 2017
@AndreasMadsen
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/10853/

@AndreasMadsen AndreasMadsen mentioned this pull request Oct 30, 2017
Merged
@AndreasMadsen
Copy link
Member Author

The CI result appears to have been lost.

CI: https://ci.nodejs.org/job/node-test-pull-request/11084/

@AndreasMadsen
Copy link
Member Author

One test failure parallel/test-async-wrap-uncaughtexception this is a known issue #16210

I will land this now.

@AndreasMadsen
Copy link
Member Author

Landed in 23a3911

@AndreasMadsen AndreasMadsen added the semver-major PRs that contain breaking changes and should be released in the next major version. label Oct 30, 2017
@refack refack added this to the 9.0.0 milestone Oct 30, 2017
jasnell pushed a commit that referenced this pull request Oct 30, 2017
@AndreasMadsen @jasnell
async_hooks: enable runtime checks by default
07d71c9 
Ref: #15454
PR-URL: #16318
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
@AndreasMadsen @Qard
async_hooks: enable runtime checks by default
a9ced7f 
Ref: nodejs/node#15454
PR-URL: nodejs/node#16318
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
@AndreasMadsen @Qard
async_hooks: enable runtime checks by default
13be443 
Ref: nodejs/node#15454
PR-URL: nodejs/node#16318
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@AndreasMadsen AndreasMadsen mentioned this pull request Nov 20, 2017
Closed
20 tasks
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@AndreasMadsen @addaleax
async_hooks: enable runtime checks by default
10b50ab 
Ref: nodejs/node#15454
PR-URL: nodejs/node#16318
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@zcbenz zcbenz mentioned this pull request May 29, 2019
Closed
6 tasks
daeyeon added a commit to daeyeon/node that referenced this pull request Jun 5, 2022
@daeyeon
src: remove a stale comment in async_hooks
1681420 
This removes a comment relevant to runtime checks for `async_hooks`.

Even if `async_hooks` is experimental, the check pointed by the comment
is performed as default unless either `--no-force-async-hooks-checks`
is given from CLI arguments or any async_hook is enabled.

Refs: nodejs#16318
Refs: nodejs#15454 (comment)

Signed-off-by: Daeyeon Jeong [email protected]
@daeyeon daeyeon mentioned this pull request Jun 5, 2022
Merged
daeyeon added a commit to daeyeon/node that referenced this pull request Jun 5, 2022
@daeyeon
src: remove a stale comment in async_hooks
9108880 
This removes a comment relevant to runtime checks for `async_hooks`.

Even if `async_hooks` is experimental, the check pointed by the comment
is performed as default unless `--no-force-async-hooks-checks` is given
from CLI arguments.

Refs: nodejs#16318
Refs: nodejs#15454 (comment)

Signed-off-by: Daeyeon Jeong [email protected]
daeyeon added a commit to daeyeon/node that referenced this pull request Jun 5, 2022
@daeyeon
src: remove a stale comment in async_hooks
3d249ee 
This removes a comment relevant to runtime checks for `async_hooks`.

Even if `async_hooks` is experimental, the check pointed by the comment
is performed as default unless `--no-force-async-hooks-checks` is given
from CLI arguments.

Refs: nodejs#16318
Refs: nodejs#15454 (comment)

Signed-off-by: Daeyeon Jeong [email protected]
daeyeon added a commit to daeyeon/node that referenced this pull request Jun 5, 2022
@daeyeon
src: remove a stale comment in async_hooks
4fd0cf8 
This removes a comment relevant to runtime checks for `async_hooks`.

Even if `async_hooks` is experimental, the check pointed by the comment
is performed as default unless `--no-force-async-hooks-checks` is given
from CLI arguments.

Refs: nodejs#16318
Refs: nodejs#15454 (comment)

Signed-off-by: Daeyeon Jeong [email protected]
daeyeon added a commit to daeyeon/node that referenced this pull request Jun 19, 2022
@daeyeon
src: remove a stale comment in async_hooks
c9a0477 
This removes a comment relevant to runtime checks for `async_hooks`.

Even if `async_hooks` is experimental, the check pointed by the comment
is performed as default unless `--no-force-async-hooks-checks` is given
from CLI arguments.

Refs: nodejs#16318
Refs: nodejs#15454 (comment)

Signed-off-by: Daeyeon Jeong [email protected]
aduh95 pushed a commit that referenced this pull request Jun 30, 2022
@daeyeon
src: remove a stale comment in async_hooks
3b0995e 
This removes a comment relevant to runtime checks for `async_hooks`.

Even if `async_hooks` is experimental, the check pointed by the comment
is performed as default unless `--no-force-async-hooks-checks` is given
from CLI arguments.

Refs: #16318
Refs: #15454 (comment)

Signed-off-by: Daeyeon Jeong [email protected]

PR-URL: #43317
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
@daeyeon @targos
src: remove a stale comment in async_hooks
5ae30bf 
This removes a comment relevant to runtime checks for `async_hooks`.

Even if `async_hooks` is experimental, the check pointed by the comment
is performed as default unless `--no-force-async-hooks-checks` is given
from CLI arguments.

Refs: #16318
Refs: #15454 (comment)

Signed-off-by: Daeyeon Jeong [email protected]

PR-URL: #43317
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
targos pushed a commit that referenced this pull request Jul 20, 2022
@daeyeon @targos
src: remove a stale comment in async_hooks
c5a822e 
This removes a comment relevant to runtime checks for `async_hooks`.

Even if `async_hooks` is experimental, the check pointed by the comment
is performed as default unless `--no-force-async-hooks-checks` is given
from CLI arguments.

Refs: #16318
Refs: #15454 (comment)

Signed-off-by: Daeyeon Jeong [email protected]

PR-URL: #43317
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@daeyeon @targos
src: remove a stale comment in async_hooks
26e4dc8 
This removes a comment relevant to runtime checks for `async_hooks`.

Even if `async_hooks` is experimental, the check pointed by the comment
is performed as default unless `--no-force-async-hooks-checks` is given
from CLI arguments.

Refs: #16318
Refs: #15454 (comment)

Signed-off-by: Daeyeon Jeong [email protected]

PR-URL: #43317
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@daeyeon @guangwong
src: remove a stale comment in async_hooks
0ee391a 
This removes a comment relevant to runtime checks for `async_hooks`.

Even if `async_hooks` is experimental, the check pointed by the comment
is performed as default unless `--no-force-async-hooks-checks` is given
from CLI arguments.

Refs: nodejs/node#16318
Refs: nodejs/node#15454 (comment)

Signed-off-by: Daeyeon Jeong [email protected]

PR-URL: nodejs/node#43317
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

+1 more reviewer

@refack refack refack approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AndreasMadsen @refack @addaleax @nodejs-github-bot