refactor away test/inspector #16197
Closed
refactor away test/inspector #16197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
mscdex
added
inspector
|
@nodejs/v8-inspector |
|
@maclover7 A third bullet point might be "evaluate if any of these tests can/should be moved to parallel". |
bnoordhuis
approved these changes
Oct 15, 2017
There was a problem hiding this comment.
You could use common.fixtures.path('inspector-global-function.js') here.
Makefile
Outdated
There was a problem hiding this comment.
Can you also remove it from vcbuild.bat? (Two mentions.)
cjihrig
approved these changes
Oct 15, 2017
refack
reviewed
Oct 15, 2017
test/inspector/inspector.status
Outdated
There was a problem hiding this comment.
Shouldn't these be moved to test/parallel/parallel.status
There was a problem hiding this comment.
Good catch -- thank you!
refack
approved these changes
Oct 16, 2017
jasnell
approved these changes
Oct 16, 2017
|
Several related failures in CI, including linting issues. |
|
@jasnell fixed linter issue and moved one of the tests to sequential, would you be willing to run CI again? |
refack
pushed a commit
to refack/node
that referenced
this pull request
Oct 17, 2017
* remove inspector directory artifacts PR-URL: nodejs#16197 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 978629c 10x! 🎉 |
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
* remove inspector directory artifacts PR-URL: #16197 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 18, 2017
* remove inspector directory artifacts PR-URL: nodejs/node#16197 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Cross-ref: #16281 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #13622, cc @Trott @refack
Tried to handle as much as I could in this PR, but there here are some things I'd like to handle in separate PRs:
inspector-helper.jsto a proper "common" module (write basic docs, etc.)test/inspectorare gonetest/parallelChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test