child_process: fix memory leak in .fork() #15679
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Entries in the `net.Server#_workers` array that is used to track handles sent from the master to workers were not deleted when a worker exited, resulting in a slow but inexorable memory leak. Fixes: nodejs#15651
jasnell
approved these changes
Sep 29, 2017
lpinca
approved these changes
Sep 30, 2017
jasnell
pushed a commit
that referenced
this pull request
Oct 1, 2017
Entries in the `net.Server#_workers` array that is used to track handles sent from the master to workers were not deleted when a worker exited, resulting in a slow but inexorable memory leak. PR-URL: #15679 Fixes: #15651 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in 2e59ec0 |
|
This doesn't land cleanly in v8.x. Could you please backport? Also feel free to let me know if another PR is blocking this |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 4, 2017
Entries in the `net.Server#_workers` array that is used to track handles sent from the master to workers were not deleted when a worker exited, resulting in a slow but inexorable memory leak. PR-URL: nodejs/node#15679 Fixes: nodejs/node#15651 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this pull request
Oct 29, 2017
Entries in the `net.Server#_slaves` array that is used to track handles sent from the master to workers were not deleted when a worker exited, resulting in a slow but inexorable memory leak. PR-URL: nodejs#15679 Fixes: nodejs#15651 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
v8.x: #16586 |
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
Entries in the `net.Server#_slaves` array that is used to track handles sent from the master to workers were not deleted when a worker exited, resulting in a slow but inexorable memory leak. PR-URL: #15679 Backport-PR-URL: #16586 Fixes: #15651 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Oct 31, 2017
Entries in the `net.Server#_slaves` array that is used to track handles sent from the master to workers were not deleted when a worker exited, resulting in a slow but inexorable memory leak. PR-URL: #15679 Backport-PR-URL: #16586 Fixes: #15651 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
|
Should this be backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entries in the
net.Server#_workersarray that is used to track handlessent from the master to workers were not deleted when a worker exited,
resulting in a slow but inexorable memory leak.
Fixes: #15651
CI: https://ci.nodejs.org/job/node-test-pull-request/10332/