Skip to content

test: verify napi_get_property() walks prototype #13961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2017
Merged

test: verify napi_get_property() walks prototype #13961

merged 1 commit into from
Jun 30, 2017

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jun 28, 2017

Refs: #13925
R= @mhdawson

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Jun 28, 2017
@cjihrig cjihrig mentioned this pull request Jun 28, 2017
Closed
mhdawson
mhdawson approved these changes Jun 28, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjihrig
Copy link
Contributor Author

cjihrig commented Jun 30, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8895/

@cjihrig
test: verify napi_get_property() walks prototype
0f1888f 
Refs: nodejs#13925
PR-URL: nodejs#13961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@cjihrig cjihrig merged commit 0f1888f into nodejs:master Jun 30, 2017
@cjihrig cjihrig deleted the get-prop-proto branch June 30, 2017 19:28
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 3, 2017
@cjihrig @addaleax
test: verify napi_get_property() walks prototype
26ad2e6 
Refs: nodejs#13925
PR-URL: nodejs#13961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@addaleax addaleax mentioned this pull request Jul 3, 2017
Merged
addaleax pushed a commit that referenced this pull request Jul 11, 2017
@cjihrig @addaleax
test: verify napi_get_property() walks prototype
ab85fc9 
Refs: #13925
PR-URL: #13961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@cjihrig @addaleax
test: verify napi_get_property() walks prototype
f400939 
Refs: #13925
PR-URL: #13961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
@cjihrig
test: verify napi_get_property() walks prototype
922ea46 
Refs: nodejs#13925
PR-URL: nodejs#13961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@cjihrig @MylesBorins
test: verify napi_get_property() walks prototype
a0cf9b7 
Refs: #13925
Backport-PR-URL: #19447
PR-URL: #13961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@mhdawson mhdawson mhdawson approved these changes

+1 more reviewer

@evanlucas evanlucas evanlucas approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @jasnell @evanlucas @addaleax @mhdawson @MylesBorins @nodejs-github-bot