Skip to content

test: fix setTimeout, add const, remove unused var #10207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

test: fix setTimeout, add const, remove unused var #10207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions test/parallel/test-domain.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
// Simple tests of most basic domain functionality.

require('../common');
var assert = require('assert');
var domain = require('domain');
var events = require('events');
var fs = require('fs');
const assert = require('assert');
const domain = require('domain');
const events = require('events');
const fs = require('fs');
var caught = 0;
var expectCaught = 0;

Expand Down Expand Up @@ -137,8 +137,8 @@ d.run(function() {
// pretty common error.
console.log(stat.isDirectory());
});
});
});
}, 1);
}, 1);
});
});
expectCaught++;
Expand All @@ -148,7 +148,7 @@ expectCaught++;
d.run(function() {
setTimeout(function() {
throw new Error('implicit timer');
});
}, 1);
});
expectCaught++;

Expand All @@ -162,7 +162,7 @@ expectCaught++;
// get rid of the `if (er) return cb(er)` malarky, by intercepting
// the cb functions to the domain, and using the intercepted function
// as a callback instead.
function fn(er) {
function fn() {
throw new Error('This function should never be called!');
}

Expand Down