URL parser behaviour change in 18.16.0

[nabinked]

18.15.0

new URL(HTTP://AMAZON.COM).href gives http://amazon.com/

18.16.0
new URL(HTTP://AMAZON.COM).href gives http://amaZon.com/

It seems the capital letter Z is not lower cased. Is that expected or is it a regression ?

[KhafraDev]

cc @nodejs/url

[Trott]

I'm able to reproduce this:

➜  ~ node
Welcome to Node.js v18.16.0.
Type ".help" for more information.
> new URL('HTTP://AMAZON.COM').href
'http://amaZon.com/'
> 

Node.js 18.16.0 uses Ada for parsing while 18.15.0 does not, so I strongly suspect this is either a bug in Ada or a bug in Node.js that was introduced as part of the change set to include Ada.

@anonrig @lemire

[Trott]

Node.js 19.7.0 and newer has this same issue. 19.6.1 does not. And again, 19.7.0 is the version where Ada is introduced.

[anonrig]

I will fix this in Ada. Thanks for reporting.

[lemire]

That's odd.

[lemire]

Wow.

[anonrig]

@lemire's pull request fixed this in Ada. We'll release a new version.