-
-
Notifications
You must be signed in to change notification settings - Fork 33.3k
Closed
Labels
duplicateIssues and PRs that are duplicates of other issues or PRs.Issues and PRs that are duplicates of other issues or PRs.httpIssues or PRs related to the http subsystem.Issues or PRs related to the http subsystem.
Description
Lines 78 to 82 in 15e41a9
var ParserIncomingMessage = parser.socket && parser.socket.server ? | |
parser.socket.server[kIncomingMessage] : IncomingMessage; | |
parser.incoming = new ParserIncomingMessage(parser.socket); | |
parser.incoming.httpVersionMajor = versionMajor; |
Due to this line of code, if parser.socket.server[kIncomingMessage]
is undefined
, an error will be thrown on the line below where the ParserIncomingMessage is constructed. A simple additional check here would solve this issue. A few libraries have cropped this up in socket.io
, ws
and some others that weren't happening in previous versions of node.
Node version: 9.6.0
Platform: OSX
Metadata
Metadata
Assignees
Labels
duplicateIssues and PRs that are duplicates of other issues or PRs.Issues and PRs that are duplicates of other issues or PRs.httpIssues or PRs related to the http subsystem.Issues or PRs related to the http subsystem.