Allow --perf-prof an --perf-basic-prof in NODE_OPTIONS

[dottedmag]

Profiling Node.js programs which spawn another Node.js processes using Linux prof is unnecessarily hard: new processes use executable from the parent process, so it is not possible to add a shell wrapper around Node to add --perf-prof to a subprocess, one has to find all the places where subprocesses are spawned and add the argument there.

NODE_OPTIONS is perfect for this task (just run the top-level process with it and all subtree will emit profiling data), but it does not support --perf-prof or --perf-basic-prof at the moment.

Please add it.

[juggernaut451]

is this issue stil open @dottedmag ?

[dottedmag]

Yes, it is. #17600 is not yet merged, and there is no --perf-prof/--perf-basic-prof in whitelist in src/node.cc.

[juggernaut451]

#17600 is still open. Making another PR would not be a good option until it is rejected

[TimothyGu]

Fixed in #17600.