test: good-second-contribution — tracking tests that need some more 💘

[refack]

A very biased list of tests that could enjoy some non-trivial refactoring

1. Make test compliant with the test writing guide
2. Make sure the test has a general description (PR or issue references most welcome)
3. Make sure test cases are well separated (IIFE, functions, or just scopes) and documented
4. Refactor away non-trivial micro-test-harnesses — example sequential/test-debugger-debug-brk.js
5. Proper use of test/common utilities

• parallel/test-domain-abort-on-uncaught.js
• sequential/test-debugger-debug-brk.js

new entries

• parallel/test-console.js - after console: coerce label to string in console.time() #14643 lands this test should assert the expected outputs. Currently it only checks that values are written to stdout and don't throw.

[Trott]

#14541

[refack]

#14541

I was thinking something more extensive, and obviously the "list" is going to get longer...

[refack]

Like what you did in #14534

[refack]

@nodejs/testing please add/remove/comment/edit

[shivanth]

Can I take this up ?

[refack]

Can I take this up ?

Sure. If you need any help, ping me (here or on IRC).
Also if you find any other tests that are written in an outdated style, post them here, and I'll add them to the list.

[oantoro]

Hi @refack

I am looking for an issue for my first contribution. May be I can work on this?

[shivanth]

@okyantoro @refack A little with held upwith stuffs, Feel free to reassign this

[oantoro]

I observed some test files and I found parallel/test-http-methods.js only covered GET, HEAD and POST and the last case compares the http.METHODS with http.METHODS.sort()
My question is why is just those three methods covered? Is it okay to add cases to check existence of other methods like PUT, DELETE etc?
Thanks