-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
Closed
Labels
testIssues and PRs related to the tests.Issues and PRs related to the tests.wipIssues and PRs that are still a work in progress.Issues and PRs that are still a work in progress.
Description
- Version: *
- Platform: *
- Subsystem: test
Ref: #13623 (comment)
as reported by @cjihrig:
common.expectsError()
is subtly broken. It relies oninstanceof
to check the error type. So aTypeError
is an instance ofError
, which is why this passed. The simplest fix might be to checkerror.constructor
inside ofcommon.expectsError()
. But that will require updating a bunch of tests because we're now using custom errors all over the place.
Metadata
Metadata
Assignees
Labels
testIssues and PRs related to the tests.Issues and PRs related to the tests.wipIssues and PRs that are still a work in progress.Issues and PRs that are still a work in progress.