-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
Closed
Labels
cryptoIssues and PRs related to the crypto subsystem.Issues and PRs related to the crypto subsystem.questionIssues that look for answers.Issues that look for answers.
Description
e83a41a introduced an internal enableTicketKeyCallback
method on SecureContext
s, without documentation or usage in JS land. It’s only mentioned in one of the test files, test/parallel/test-https-resume-after-renew.js
. So … Should this functionality stay? Should it go? And generally, what is it?
I stumbled upon this while looking into #13142 (comment) to see whether SecureContext
should inherit from AsyncWrap
, but I can’t really tell how the MakeCallback
there works and whether it should really be one, so I thought it might be good to just ask about it.
@indutny @nodejs/crypto
Metadata
Metadata
Assignees
Labels
cryptoIssues and PRs related to the crypto subsystem.Issues and PRs related to the crypto subsystem.questionIssues that look for answers.Issues that look for answers.