not support file URLs containing drive specifiers (e.g., "file:///c:/path")

[mayyamus]

• Version:All
• Platform:windows
• Subsystem:fs

Remove leading slashes if followed by drive specifier.As a side effect,"/c:/path" can be used as an alternative to "c:/path".

[bnoordhuis]

It's not entirely clear what you are requesting. Can you post some example code and explain how you would like it to work?

[bzoz]

@mayyamus I'm also not sure what is the issue here. With node I get:

> fs.readFileSync('/c:/test')
Error: ENOENT: no such file or directory, open 'C:\c:\test'

[jasnell]

@bnoordhuis @bzoz, if I understand correctly, the issue is that with file:// URLs that contain Windows drive letters, e.g. file:///C:/Test, the pathname component is output as /C:/Test. Conceivably, on Windows, the fs module could be modified to detect if the path used in fs methods follows this pattern and could strip the leading / off if the immediately following segment is a drive letter.

Alternatively, the fs module could be modified to accept file:// URL objects as the path, which would be fairly interesting on it's own.

const fs = require('fs');
const URL = require('url').URL;
const myFileURL = new URL('file:///C:/Test/foo.txt');
fs.readFile(myFileURL, (err, data) => { /**...**/ });

[mayyamus]

@jasnell @bzoz @bnoordhuis Adding a method support URL is neccessary,so fs'constructors more perfectible.In final,you also should remove first slash('/') in normalize method.

[bnoordhuis]

Conceivably, on Windows, the fs module could be modified to detect if the path used in fs methods follows this pattern and could strip the leading / off if the immediately following segment is a drive letter.

That seems too much like second-guessing the user. There are probably edge cases (UNC paths?) where it breaks down.

Alternatively, the fs module could be modified to accept file:// URL objects as the path, which would be fairly interesting on it's own.

That might be an acceptable change.

[jasnell]

There are probably edge cases (UNC paths?) where it breaks down.

Using the new URL parser it should not specifically because the parsing algorithm handles Windows drive letters as a special case. What we can essentially do here is this:

1. If path is a string prefixed with file://, we create a URL object
2. Accept URL objects passed in as the path
3. If protocol is anything other than file://, throw
4. If hostname is set in the URL, then it is a UNC path, otherwise it's a local path
5. If it's a local path, strip the leading /, otherwise construct the appropriate UNC path

[mayyamus]

var _url = require('url');
var urlInfo = (0,_url.parse)('file:///c:/path');
var path = urlInfo.path;
Now,path'value is '/c:/path'.so,all input path(type is string) must check:
0. path.length >=3
1.path.charCodeAt(0) is slash('/')
2.path.charCodeAt(1) is windows drive letters
3.path.charCodeAt(2) is ':'
if all passed,then is local file.so should strip the leading slash('/')