feat: support IBM Open XL C/C++ & PL/I compilers on z/OS #2742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open XL C/C++ for z/OS (C invocation: clang, ibm-clang, or ibm-clang64) is LLVM-based, and doesn't support XL C/C++'s -q flags. Environment variable CC is set starting with Node.js v18 for z/OS which requires clang or ibm-clang64 compiler, but CC may not be set in older versions (which required njsc or xlclang), hence default to njsc to support older versions. Also fix defines of _ALL_SOURCE and _UNIX03_SOURCE to match how they're used.
|
Hi Richard @richardlau please review when you have a chance. |
richardlau
reviewed
Oct 3, 2022
There was a problem hiding this comment.
Looks okay but the changes under gyp should be upstreamed to https://github.com/nodejs/gyp-next.
Changed is now in nodejs/gyp-next#178
Done, please see nodejs/gyp-next#178. |
|
I deleted make.py rather than reverting its change; will resolve in another PR. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm testpassesDescription of change
Open XL C/C++ for z/OS (C invocation: clang, ibm-clang, or ibm-clang64) is LLVM-based, and doesn't support XL C/C++'s -q flags. Environment variable CC is set starting with Node.js v18 for z/OS which requires clang or ibm-clang64 compiler, but CC may not be set in older versions (which required njsc or xlclang), hence default to njsc to support older versions.
Also fix defines of _ALL_SOURCE and _UNIX03_SOURCE to match how they're used.
Accompanying change to
gyp/pylib/gyp/generator/make.pynow deleted from this PR per #2742 (review) and now in nodejs/gyp-next#178.