node --version #2122
Closed
node --version #2122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(title of the PR was original commit summary, commit now has a new summary, btw) |
|
made redundant by #2021 thankfully, will need to deal with the 5.x branch though but I might trim that to Node 8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit was on
master, I think probably accidentally as I don't believe there's a PR for it and there wasn't any metadata. I've pulled it out and force pushed a newmasterimpacting the two commits following it, which I think should be fine.This one looks necessary, but maybe the answer here is to remove the
Node.js 6 & Python 3.8 on Linuxinstead of having a manual skip. I imagine this was a testing commit that accidentally made it ontomaster@cclauss?Not a big deal but let's figure out what the final form is and get it landed ASAP.