gyp: list(dict) so we can del dict[key] while iterating #2009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
changed the title
rvagg
approved these changes
Jan 1, 2020
|
@cclauss any idea why this doesn't show up in our tests & linting and doesn't appear to be a widespread problem? Is it likely just some specific thing that an addon is doing with gyp that we're not covering that's hitting this code that's not normally hit? |
|
Agreed. It is a situation that must be happening rarely in the wild and not covered in our test cases. |
rvagg
pushed a commit
that referenced
this pull request
Jan 6, 2020
Fixes #1998 Reviewed-By: Rod Vagg <[email protected]> PR-URL: #2009
|
landed 14f2a07 |
rvagg
pushed a commit
that referenced
this pull request
Jan 6, 2020
Fixes #1998 Reviewed-By: Rod Vagg <[email protected]> PR-URL: #2009
rvagg
pushed a commit
that referenced
this pull request
Feb 3, 2020
Fixes #1998 Reviewed-By: Rod Vagg <[email protected]> PR-URL: #2009
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1998
Checklist
npm install && npm testpassesDescription of change