install: always download SHA sums on Windows #1926
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yeah, I guess this is reasonable. @richardlau @joaocgreis @bzoz can one of you sanity check this? |
joaocgreis
approved these changes
Oct 17, 2019
There was a problem hiding this comment.
It would be good to be able to specify the lib files using an option as well, but this is certainly better than what is there now. Thanks @s100!
richardlau
approved these changes
Oct 19, 2019
rvagg
pushed a commit
that referenced
this pull request
Oct 21, 2019
PR-URL: #1926 Reviewed-By: João Reis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
|
good stuff, landed in 032db2a |
|
hey, anyone think this one might be |
|
I don't see why. Downloads already happen for the .lib files, this adds a new one but fixes the breakage. |
rvagg
pushed a commit
that referenced
this pull request
Nov 18, 2019
PR-URL: #1926 Reviewed-By: João Reis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm testpassesDescription of change
Fixes #1924. Mitigates #1002.
On Windows, we download
node.liband check its SHA256 sum. That means that on Windows, we also need to download the expected SHA256 sums to check against, always.