Move from __future__ import to the top of the file #1789
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we're getting out of sync with refack/GYP, would you mind upstreaming to there too so when we do an upgrade we don't overwrite. also tests to find this in the future would be nice, I guess we don't do any vcproj builds in our tests |
rvagg
approved these changes
Jun 21, 2019
rvagg
pushed a commit
that referenced
this pull request
Jun 21, 2019
Fixes #1774 PR-URL: #1789 Reviewed-By: Rod Vagg <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Jun 21, 2019
Fixes #1774 PR-URL: #1789 Reviewed-By: Rod Vagg <[email protected]>
This was referenced Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1774
Checklist
npm install && npm testpassesDescription of change