Remove unused variable to fix linting on master #1561
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes linting.
Closed
refack
approved these changes
Oct 11, 2018
richardlau
approved these changes
Oct 11, 2018
refack
pushed a commit
that referenced
this pull request
Oct 14, 2018
This fixes linting. #1561 Reviewed-By: Refael Ackermann <[email protected]>
|
Landed in 3481739 |
rvagg
pushed a commit
that referenced
this pull request
Apr 24, 2019
This fixes linting. #1561 Reviewed-By: Refael Ackermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently linting fails on master because of an unused variable. This seems to have been caused by two PRs, each was run in CI without including the other: #1497 landed first, but #1521 was based on an older commit.
cc @maclover7 @gibfahn @rvagg
Checklist
npm install && npm testpasses